Fix incorrect variable name in RetrieverTool #16242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes a pydantic serialization error when using both RetrieverTool and phoenix/llamatrace. `input` is referencing the python built-in rather than the desired query input.
dosubot
bot
added
the
size:XS
logan-markewich
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change fixes a pydantic serialization error when using both RetrieverTool and phoenix/llamatrace.
inputis referencing the python built-in rather than the desired query input.Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
To reproduce, setup llamatrace on a project and use the retriever tool. Note that pydantic serialization exceptions are logged by the openinference handler.
https://github.com/Arize-ai/openinference/blob/main/python/instrumentation/openinference-instrumentation-llama-index/src/openinference/instrumentation/llama_index/_handler.py#L249-L254
Suggested Checklist: