Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oraclevs integration #16161

Merged
merged 62 commits into from
Sep 30, 2024
Merged

Conversation

rohanaggarwal7997
Copy link
Contributor

Description

This transaction integrates Oracle AI Vector Search (Vector Store, Document Loader, Summary, Embedder, Chunker) in Llamaindex.

New Package

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes

Version Bump?

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • We have our own internal unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

skmishraoracle and others added 30 commits April 10, 2024 17:44
Oracle Document Store package creation.
Oracle Document Store package creation.
Oracle document store implementation.
Oracle document store implementation.
Lint fixes.
add oracleai jupyter notebook.
delete oracleds.py
add test files.
fix oracledb imports.
fix oracledb imports in tests.
add examples (jupyter notebooks) and api_refs.
add examples (jupyter notebooks) and api_refs.
@forkhroy
Copy link

@logan-markewich could you please take a look why 'pants' tool is complaining about this?

pants tailor --check :: -docs/::

Error: 3.05 [ERROR] 1 Exception encountered:

Engine traceback:
in tailor goal

InvalidFieldException: llama-index-integrations/embeddings/llama-index-embeddings-oracleai/BUILD:1: Invalid field value for 'sources' in target llama-index-integrations/embeddings/llama-index-embeddings-oracleai:llama-index-embeddings-oracleai: Unmatched globs from llama-index-integrations/embeddings/llama-index-embeddings-oracleai:llama-index-embeddings-oracleai's sources field: ["llama-index-integrations/embeddings/llama-index-embeddings-oracleai/.py", "llama-index-integrations/embeddings/llama-index-embeddings-oracleai/.pyi"], excludes: ["llama-index-integrations/embeddings/llama-index-embeddings-oracleai/_test.py", "llama-index-integrations/embeddings/llama-index-embeddings-oracleai/test.pyi", "llama-index-integrations/embeddings/llama-index-embeddings-oracleai/conftest.py", "llama-index-integrations/embeddings/llama-index-embeddings-oracleai/test.py", "llama-index-integrations/embeddings/llama-index-embeddings-oracleai/test_.pyi", "llama-index-integrations/embeddings/llama-index-embeddings-oracleai/tests.py", "llama-index-integrations/embeddings/llama-index-embeddings-oracleai/tests.pyi"]

It is looking for .py file here llama-index-integrations/embeddings/llama-index-embeddings-oracleai/ but I think it should look to this location: llama-index-integrations/embeddings/llama-index-embeddings-oracleai/llama_index/embeddings/oracleai/ according to the design.

Please suggest how to fix it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a proper readme?

This shows up on https://llamahub.ai -- so lets make sure these contain at least the installation command and an example of how to use it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested Hari to fix

@logan-markewich
Copy link
Collaborator

logan-markewich commented Sep 29, 2024

@forkhroy fixed the pants issue -- just needed to delete the file it was complaining about and let it regenerate it 👍🏻

However, looks like tests are generally broken in a few places

@rohanaggarwal7997
Copy link
Contributor Author

Thanks @logan-markewich . I have asked @skmishraoracle to fix the vector store test issue. It seems the other tests pass cleanly. We will fix the readmes.

@rohanaggarwal7997
Copy link
Contributor Author

@logan-markewich we have fixed the error - can you please rerun the workflows

@rohanaggarwal7997
Copy link
Contributor Author

@logan-markewich can we merge it now ?

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 30, 2024
@logan-markewich logan-markewich merged commit 4db1ed1 into run-llama:main Sep 30, 2024
10 checks passed
@mckinseyalexanderfalaleev
Copy link
Contributor

@rohanaggarwal7997 Thank you for this contribution!

@logan-markewich When are you planning to release it?

raspawar pushed a commit to raspawar/llama_index that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants