-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oraclevs integration #16161
Oraclevs integration #16161
Conversation
Oracle Document Store package creation.
Oracle Document Store package creation.
Oracle document store implementation.
Oracle document store implementation.
Lint fixes.
Lint fixes.
add oracleai jupyter notebook.
add oracleai jupyter notebook.
delete oracleds.py
delete oracleds.py
add test files.
add test files.
fix oracledb imports.
fix oracledb imports.
fix oracledb imports in tests.
fix oracledb imports in tests.
add examples (jupyter notebooks) and api_refs.
add examples (jupyter notebooks) and api_refs.
addressed PR comments.
moved OracleSummary from tools to utils.
moved OracleSummary from tools to utils.
update OracleSummary
update OracleSummary
@logan-markewich could you please take a look why 'pants' tool is complaining about this? pants tailor --check :: -docs/:: Error: 3.05 [ERROR] 1 Exception encountered: Engine traceback: InvalidFieldException: llama-index-integrations/embeddings/llama-index-embeddings-oracleai/BUILD:1: Invalid field value for 'sources' in target llama-index-integrations/embeddings/llama-index-embeddings-oracleai:llama-index-embeddings-oracleai: Unmatched globs from llama-index-integrations/embeddings/llama-index-embeddings-oracleai:llama-index-embeddings-oracleai's It is looking for .py file here llama-index-integrations/embeddings/llama-index-embeddings-oracleai/ but I think it should look to this location: llama-index-integrations/embeddings/llama-index-embeddings-oracleai/llama_index/embeddings/oracleai/ according to the design. Please suggest how to fix it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a proper readme?
This shows up on https://llamahub.ai
-- so lets make sure these contain at least the installation command and an example of how to use it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested Hari to fix
llama-index-integrations/readers/llama-index-readers-oracleai/README.md
Outdated
Show resolved
Hide resolved
llama-index-integrations/embeddings/llama-index-embeddings-oracleai/README.md
Outdated
Show resolved
Hide resolved
@forkhroy fixed the pants issue -- just needed to delete the file it was complaining about and let it regenerate it 👍🏻 However, looks like tests are generally broken in a few places |
Thanks @logan-markewich . I have asked @skmishraoracle to fix the vector store test issue. It seems the other tests pass cleanly. We will fix the readmes. |
@logan-markewich we have fixed the error - can you please rerun the workflows |
@logan-markewich can we merge it now ? |
@rohanaggarwal7997 Thank you for this contribution! @logan-markewich When are you planning to release it? |
Description
This transaction integrates Oracle AI Vector Search (Vector Store, Document Loader, Summary, Embedder, Chunker) in Llamaindex.
New Package
Did I fill in the
tool.llamahub
section in thepyproject.toml
and provide a detailed README.md for my new integration or package?Version Bump?
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
make format; make lint
to appease the lint gods