add docs build to cicd #15101
Closed
add docs build to cicd #15101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
nerdai
reviewed
Aug 2, 2024
| cache-dependency-path: "**/poetry.lock" | ||
| - name: Build docs | ||
| shell: bash | ||
| run: cd docs && poetry install && poetry run mkdocs build |
There was a problem hiding this comment.
would we still have to python ./docs/prepare_for_build.py locally?
There was a problem hiding this comment.
I think so, since that script creates new files that need to be committed
|
tbh, this is too slow to add cicd right now. I would love if mkdocs could cache the notebook conversions, but looks like thats still a todo on their end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.