Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass aws_region_name to get_aws_service_client() in SageMakerLLM #12000

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

a-a-ronchen
Copy link

Description

2-line fix for #11999, allows the SageMakerLLM examplein the documentation to run without error.

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 16, 2024
@a-a-ronchen a-a-ronchen changed the title Change argument aws_region_name to region_name Pass aws_region_name to get_aws_service_client() in SageMakerLLM Mar 16, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 17, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Apr 7, 2024
@logan-markewich logan-markewich enabled auto-merge (squash) April 9, 2024 17:37
@brycecf
Copy link
Contributor

brycecf commented May 28, 2024

@a-a-ronchen @logan-markewich Any updates on this? Looks like a simple linting fix is all that is blocking this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants