add warning in case model is present in available models

run-llama · Oct 4, 2024 · 81584b6 · 81584b6
1 parent 8af9d32
commit 81584b6
Show file tree

Hide file tree

Showing 6 changed files with 48 additions and 12 deletions.
diff --git a/...tegrations/embeddings/llama-index-embeddings-nvidia/llama_index/embeddings/nvidia/base.py b/...tegrations/embeddings/llama-index-embeddings-nvidia/llama_index/embeddings/nvidia/base.py
@@ -200,10 +200,13 @@ def _validate_model(self, model_name: str) -> None:
         """
         if self._is_hosted:
             if model_name not in MODEL_ENDPOINT_MAP:
-                raise ValueError(
-                    f"Model {model_name} is incompatible with client {self.class_name()}. "
-                    f"Please check `{self.class_name()}.available_models()`."
-                )
+                if model_name in [model.id for model in self._client.models.list()]:
+                    warnings.warn(f"Unable to determine validity of {model_name}")
+                else:
+                    raise ValueError(
+                        f"Model {model_name} is incompatible with client {self.class_name()}. "
+                        f"Please check `{self.class_name()}.available_models()`."
+                    )
         else:
             if model_name not in [model.id for model in self.available_models]:
                 raise ValueError(f"No locally hosted {model_name} was found.")

diff --git a/...dex-integrations/embeddings/llama-index-embeddings-nvidia/tests/test_embeddings_nvidia.py b/...dex-integrations/embeddings/llama-index-embeddings-nvidia/tests/test_embeddings_nvidia.py
@@ -106,3 +106,12 @@ def test_model_incompatible_client_model() -> None:
     with pytest.raises(ValueError) as msg:
         NVIDIAEmbedding(api_key="BOGUS", model=model_name)
     assert err_msg == str(msg.value)
+
+
+def test_model_incompatible_client_known_model() -> None:
+    model_name = "google/deplot"
+    warn_msg = f"Unable to determine validity"
+    with pytest.warns(UserWarning) as msg:
+        NVIDIAEmbedding(api_key="BOGUS", model=model_name)
+    assert len(msg) == 1
+    assert warn_msg in str(msg[0].message)
diff --git a/llama-index-integrations/llms/llama-index-llms-nvidia/llama_index/llms/nvidia/base.py b/llama-index-integrations/llms/llama-index-llms-nvidia/llama_index/llms/nvidia/base.py
@@ -179,10 +179,13 @@ def _validate_model(self, model_name: str) -> None:
         """
         if self._is_hosted:
             if model_name not in ALL_MODELS:
-                raise ValueError(
-                    f"Model {model_name} is incompatible with client {self.class_name()}. "
-                    f"Please check `{self.class_name()}.available_models()`."
-                )
+                if model_name in [model.id for model in self.available_models]:
+                    warnings.warn(f"Unable to determine validity of {model_name}")
+                else:
+                    raise ValueError(
+                        f"Model {model_name} is incompatible with client {self.class_name()}. "
+                        f"Please check `{self.class_name()}.available_models()`."
+                    )
         else:
             if model_name not in [model.id for model in self.available_models]:
                 raise ValueError(f"No locally hosted {model_name} was found.")

diff --git a/llama-index-integrations/llms/llama-index-llms-nvidia/tests/test_nvidia.py b/llama-index-integrations/llms/llama-index-llms-nvidia/tests/test_nvidia.py
@@ -330,3 +330,12 @@ def test_model_incompatible_client_model() -> None:
     with pytest.raises(ValueError) as msg:
         NVIDIA(model=model_name)
     assert err_msg == str(msg.value)
+
+
+def test_model_incompatible_client_known_model() -> None:
+    model_name = "google/deplot"
+    warn_msg = f"Unable to determine validity"
+    with pytest.warns(UserWarning) as msg:
+        NVIDIA(api_key="BOGUS", model=model_name)
+    assert len(msg) == 1
+    assert warn_msg in str(msg[0].message)
diff --git a/...r/llama-index-postprocessor-nvidia-rerank/llama_index/postprocessor/nvidia_rerank/base.py b/...r/llama-index-postprocessor-nvidia-rerank/llama_index/postprocessor/nvidia_rerank/base.py
@@ -227,10 +227,13 @@ def _validate_model(self, model_name: str) -> None:
         """
         if self._is_hosted:
             if model_name not in MODEL_ENDPOINT_MAP:
-                raise ValueError(
-                    f"Model {model_name} is incompatible with client {self.class_name()}. "
-                    f"Please check `{self.class_name()}.available_models()`."
-                )
+                if model_name in [model.id for model in self._get_models()]:
+                    warnings.warn(f"Unable to determine validity of {model_name}")
+                else:
+                    raise ValueError(
+                        f"Model {model_name} is incompatible with client {self.class_name()}. "
+                        f"Please check `{self.class_name()}.available_models()`."
+                    )
         else:
             if model_name not in [model.id for model in self.available_models]:
                 raise ValueError(f"No locally hosted {model_name} was found.")

diff --git a/...ocessor/llama-index-postprocessor-nvidia-rerank/tests/test_postprocessor_nvidia_rerank.py b/...ocessor/llama-index-postprocessor-nvidia-rerank/tests/test_postprocessor_nvidia_rerank.py
@@ -222,3 +222,12 @@ def test_model_incompatible_client() -> None:
     with pytest.raises(ValueError) as msg:
         NVIDIARerank(api_key="BOGUS", model=model_name)
     assert err_msg == str(msg.value)
+
+
+def test_model_incompatible_client_known_model() -> None:
+    model_name = "google/deplot"
+    warn_msg = f"Unable to determine validity"
+    with pytest.warns(UserWarning) as msg:
+        NVIDIARerank(api_key="BOGUS", model=model_name)
+    assert len(msg) == 1
+    assert warn_msg in str(msg[0].message)