refact: Simple message queue refactoring #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #361
While working on #361 I found out it wasn't that easy to introduce the concept of topic in
SimpleMessageQueuebecause there wasn't a clear separation between "client" and "server". With other flavors of message queues, the client is the one responsible for managing consumers, while the server is the actual broker service (Redis, Kafka and the likes). But the simple message queue also has a "server" part that acts as an in-memory storage.With this PR, the server and the client are clearly separated, and only
SimpleMessageQueuederives fromAbstractMessageQueue, while the server class is just an object. This way, the simple message queue isn't special anymore, and it behaves exactly like the others.