[feat] Add send event endpoints to api server #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerdai
commented
Dec 18, 2024
| @@ -90,7 +90,7 @@ async def test_session_collection_list(client: Any) -> None: | |||
| @pytest.mark.asyncio | |||
| async def test_task_results(client: Any) -> None: | |||
| res = TaskResult(task_id="a_result", history=[], result="some_text", data={}) | |||
| client.request.return_value = mock.MagicMock(json=lambda: res.model_dump_json()) | |||
| client.request.return_value = mock.MagicMock(json=lambda: res.model_dump()) | |||
There was a problem hiding this comment.
I think we had this incorrectly mocked on the basis that httpx.Response.json() returns a dict rather than a str.
I ran into this error when running the new hitl e2e test and the TaskResult was failing Pydantic's validation. The modification made in this PR resolves it.
(The naming on Pydantic is confusing... model_dump works with dict and model_dump_json works with str.)
nerdai
commented
Dec 18, 2024
nerdai
commented
Dec 20, 2024
| @@ -109,6 +109,18 @@ async def send_event(self, service_name: str, task_id: str, ev: Event) -> None: | |||
| url = f"{self.client.control_plane_url}/sessions/{self.id}/tasks/{task_id}/send_event" | |||
| await self.client.request("POST", url, json=event_def.model_dump()) | |||
|
|
|||
| async def send_event_def(self, task_id: str, ev_def: EventDefinition) -> None: | |||
There was a problem hiding this comment.
So, I needed to add this in order for the apiserver to be able to just forward along an EventDefinition to the WorkflowService
nerdai
changed the title
logan-markewich
approved these changes
Dec 22, 2024
masci
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new endpoint in api server allowing users to post a new
Eventthat gets sent to a running workflow of a specified deployment.I've also added the
send_event()method to theTaskapiserver/model class.