feat: make the KV store configurable via env vars #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @step() | ||
| async def run_step(self, ev: StartEvent) -> StopEvent: | ||
| message = str(ev.get("message", "")) | ||
| return StopEvent(result=f"Message received: {message}") |
There was a problem hiding this comment.
Maybe a better example would be something that keeps state/context between runs? Like a counter?
| @step() | ||
| async def run_step(self, ctx: Context, ev: StartEvent) -> StopEvent: | ||
| amount = float(ev.get("amount", 0.0)) | ||
| total = await ctx.get("total", 0.0) + amount |
There was a problem hiding this comment.
An await and + without brackets works? TIL :D
There was a problem hiding this comment.
You made me curious :) indeed await is pretty high in the order of precedence, right after call() https://docs.python.org/3/reference/expressions.html#operator-precedence
logan-markewich
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #370
Allow passing a URI string to the control plane constructor to build a KV store. For now only Redis and MongoDB are supported, to be considered reference implementation. Ideally we could support all the available store in llama_index.