Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the new SDK within the api server #372

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Use the new SDK within the api server #372

merged 2 commits into from
Nov 20, 2024

Conversation

masci
Copy link
Member

@masci masci commented Nov 20, 2024 •
edited
Loading

Fixes #337 #334

  • Use the new Client
  • Remove generic JSONResponses in favor of specific types
  • Consolidated the apiserver portion of the SDK: go lazy and stop pre-filling items when creating collections. Will remove the field in a subsequent PR.

@masci masci linked an issue Nov 20, 2024 that may be closed by this pull request
Refactor Python SDK #334
Closed
4 tasks
@coveralls
Copy link

Coverage Status

coverage: 72.055% (-0.02%) from 72.076%
when pulling 6cc06d6 on massi/apiserver-sdk
into d7066e7 on main.

@logan-markewich logan-markewich added the enhancement New feature or request label Nov 20, 2024
logan-markewich
logan-markewich approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@logan-markewich logan-markewich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay actual response types. Looks good!

@logan-markewich logan-markewich merged commit acd75fd into main Nov 20, 2024
10 checks passed
@logan-markewich logan-markewich deleted the massi/apiserver-sdk branch November 20, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logan-markewich logan-markewich logan-markewich approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consolidate typing for responses in apiserver/control plane Refactor Python SDK
3 participants
@masci @coveralls @logan-markewich