feat: add get_task_result_stream to new client #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logan-markewich
approved these changes
Nov 7, 2024
nerdai
approved these changes
Nov 7, 2024
| except RuntimeError: | ||
| return _SyncClient(**self.model_dump()) | ||
|
|
||
| msg = "You cannot use the sync client within an async event loop - just await the async methods directly." |
There was a problem hiding this comment.
Oh, was this something we were running into before. Anyways, nice catch!
There was a problem hiding this comment.
This problem always existed but didn't run into it until @logan-markewich made me notice!
| # Generic parameter for the wrapped generator method | ||
| _P = ParamSpec("_P") | ||
| # Generic parameter for the wrapped generator method return value | ||
| _R = TypeVar("_R") |
There was a problem hiding this comment.
Possibly dumb question as perhaps I just missed this, but where are we using this generic param?
There was a problem hiding this comment.
Not dumb, leftover! I'll remove it, good catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports the last method missing from
AsyncSessionClient,get_task_result_stream.Fixes #335
Notes for the reviewer:
Coroutine[AsyncGenerator]when converted withasync_to_syncreturnAsyncGenerator, that we can't use in sync calls. To overcome this limitation,generator_wrapperwas added that consumes the async generator under the hood and returns a listClient