refact: make collections in apiserver models lazy #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return SessionCollection.instance( | ||
| make_sync=self._instance_is_sync, | ||
| client=self.client, | ||
| deployment_id=self.id, | ||
| items=items, | ||
| items={}, |
There was a problem hiding this comment.
Does a SessionCollection (or other collections) even need an items kwarg/attribute on the instance now?
There was a problem hiding this comment.
Correct, collections don't need it anymore (unless we want to introduce some sort of caching but at this stage I'd rather not)
| id=session_def.session_id, | ||
| ) | ||
| for session_def in r.json() | ||
| } | ||
| return SessionCollection.instance( |
There was a problem hiding this comment.
This makes sense to me
Conceptually, this is returning a client, and from there, you interact with it
logan-markewich
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust
client.apiserver.deploymentsandclient.apiserver.sessionsso that they don't actually load the items in a collection, deferring that tolist. This waysessionsanddeploymentscan be regular properties, accessible withoutawait.This was originally implemented for the
coreclient, this PR makes it consistent with the rest of the models.Part of #337