Add example script for ToolService with Launcher #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agentfile/orchestrators/agent.py
Outdated
| ) | ||
| else: | ||
| messages = memory.get() | ||
| response = await self.llm.apredict_and_call( | ||
| tools_plus_human, | ||
| chat_history=messages, | ||
| error_on_no_tool_call=False, |
There was a problem hiding this comment.
we should keep this line 👀 But just need the latest version of core (I updated the toml in main)
There was a problem hiding this comment.
Yeah i was confused why that was there, but my core wasn't updated on my local machine! Will make the change 👍🏼
agentfile/launchers/local.py
Outdated
| # shutdown | ||
| for task in bg_tasks: | ||
| task.cancel() | ||
| mq_task.cancel() |
There was a problem hiding this comment.
I wonder if there's a way to return the final result here too -- maybe a future improvement
There was a problem hiding this comment.
I modified this to what I think is a bit more graceful shutdown.
agentfile/launchers/local.py
Outdated
| @@ -31,10 +32,12 @@ def __init__( | |||
| services: List[BaseService], | |||
| control_plane: BaseControlPlane, | |||
| message_queue: SimpleMessageQueue, | |||
| additional_consumers: List[BaseMessageQueueConsumer] = [], | |||
There was a problem hiding this comment.
nit: we should avoid having lists as default params, due to pass-by-reference
There was a problem hiding this comment.
good catch! I removed this entirely anyways though.
nerdai
changed the title
nerdai
added a commit
that referenced
this pull request
Jul 21, 2024
* wip * put back error_on_no_tool_call=False * cleaner shutdown and UX * move registration of tool imn acall * add deregister method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.