-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KafkaMessageQueue #148
Conversation
examples/kafka/pig-latin-translation/pig_latin_translation/additional_services/task_result.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Future note: Somehow it feels like our examples should be more simple. Feels a little crazy to write this much code for a toy example. I wonder how much of this is worth baking into other abstractions in the library
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree! I think for simple local launch/single examples its easy.
But when looking to deploy these with some orchestration via docker-compose or kubernetes then I am not sure if it can be as easy as a single script.
It would be really nice to simplify the process of building a multi-agent app where we do "intend" to deploy the microservices on their own.
The pattern I've adopted here is:
- build a multi-agent app Python package
- that defines all of your microservices and launches them in their associated script
- this way we can have a single docker image and just change the command for that image to launch the service that you want to launch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added an issue to track this for us: #150 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Another queue! 💪
Alright, thanks for the review @logan-markewich! I'm pretty sure I got everything covered from your comments thru direct changes or adding some new issues in our board! Going to merge this now. 🙏🚀 |
This PR adds the
KafkaMessageQueue
which is the integration for Apache Kafka.kafka-python-ng
(the up-to-date fork ofkafka-python
) as well asaiokafka
from the same folks who producedaiohttp
.examples/kafka
folder that contain:KafkaMessageQueue
KafkaMessageQueue
KafkaMessageQueue
closes #144