Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add url field to BaseMessageQueue #151

Open
nerdai opened this issue Jul 21, 2024 · 2 comments
Open

Add url field to BaseMessageQueue #151

nerdai opened this issue Jul 21, 2024 · 2 comments
Labels
good first issue Good for newcomers P2

Comments

@nerdai
Copy link
Contributor

nerdai commented Jul 21, 2024

Description:

BaseMessageQueue is a Pydantic BaseModel that has no fields. Though, all of its subclasses so far have an url attribute. It's probably fair to assume at this point that all subclasses of this base class will contain url and so we should just include it in the base.
@nerdai nerdai added good first issue Good for newcomers P2 labels Jul 21, 2024
@nerdai nerdai mentioned this issue Jul 21, 2024
Merged
@logan-markewich logan-markewich moved this to Todo in llama-agents Jul 22, 2024
@srikary12
Copy link

@logan-markewich @nerdai Can I work on this?

@nerdai
Copy link
Contributor Author

nerdai commented Jul 22, 2024

That would be great @srikary12!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers P2
Projects
No open projects
llama-agents
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nerdai @srikary12