Clean Code and minor fixes

RuiSantos.ZocDoc.Api/Contracts/AppointmentContract.cs

@@ -22,8 +22,8 @@ public class AppointmentContract
 
     public AppointmentContract()
     {
-        this.MedicalLicense = string.Empty;
-        this.PatientSecuritySocialNumber = string.Empty;
-        this.Date = DateTime.MinValue;
+        MedicalLicense = string.Empty;
+        PatientSecuritySocialNumber = string.Empty;
+        Date = DateTime.MinValue;
     }
 }

RuiSantos.ZocDoc.Api/Contracts/PatientAppointmentsContract.cs

@@ -19,13 +19,13 @@ public class PatientAppointmentsContract
 
     public PatientAppointmentsContract()
     {
-        this.Doctor = new DoctorContract();
-        this.Date = DateTime.Now;
+        Doctor = new DoctorContract();
+        Date = DateTime.Now;
     }
 
     public PatientAppointmentsContract(Doctor doctor, DateTime date)
     {
-        this.Doctor = new DoctorContract(doctor);
-        this.Date = date;
+        Doctor = new DoctorContract(doctor);
+        Date = date;
     }
 }

RuiSantos.ZocDoc.Api/Controllers/SpecialtiesController.cs

@@ -23,7 +23,7 @@ public SpecialtiesController(MedicalSpecialtiesManagement management)
     /// <response code="404">No medical specialties found.</response>
     [HttpGet]
     [ProducesResponseType(StatusCodes.Status200OK)]
-    [ProducesResponseType(StatusCodes.Status404NotFound)]        
+    [ProducesResponseType(StatusCodes.Status404NotFound)]
     public async Task<ActionResult<IEnumerable<string>>> GetAsync()
     {
         var result = await management.GetMedicalSpecialitiesAsync();

RuiSantos.ZocDoc.Api/Core/ReApplyOptionalRouteParameterOperationFilter.cs

@@ -6,7 +6,7 @@ namespace RuiSantos.ZocDoc.Api.Core;
 
 internal class ReApplyOptionalRouteParameterOperationFilter : IOperationFilter
 {
-    const string captureName = "routeParameter";
+    private const string captureName = "routeParameter";
 
     public void Apply(OpenApiOperation operation, OperationFilterContext context)
     {

RuiSantos.ZocDoc.Core.Tests/Core/TaskExtensions.cs

@@ -5,7 +5,7 @@ internal static class TaskExtensions
     public static async Task<List<T>> ToListAsync<T>(this IAsyncEnumerable<T> enumerable)
     {
         var result = new List<T>();
-        await foreach (var item in enumerable) result.Add(item);    
+        await foreach (var item in enumerable) result.Add(item);
         return result;
     }
 }

RuiSantos.ZocDoc.Core.Tests/Factories/AppointmentsFactory.cs

@@ -4,7 +4,7 @@ namespace RuiSantos.ZocDoc.Core.Tests.Factories;
 
 internal static class AppointmentsFactory
 {
-    static readonly DateTime StartTime = new(2022, 1, 3, 8, 0, 0);
+    private static readonly DateTime StartTime = new(2022, 1, 3, 8, 0, 0);
     public static IEnumerable<Appointment> Create(int elements = 1)
         => Enumerable.Range(0, elements).Select(i => new Appointment(StartTime.AddHours(i)));
 }

RuiSantos.ZocDoc.Core.Tests/Factories/DoctorFactory.cs

@@ -27,10 +27,10 @@ public static Doctor SetSpecialties(this Doctor doctor, params string[] specialt
     public static Doctor SetOfficeHours(this Doctor doctor, params OfficeHour[] officeHours)
     {
         doctor.OfficeHours.Clear();
-        
+
         if (officeHours.Any())
             doctor.OfficeHours.AddRange(officeHours);
-        
+
         return doctor;
     }
 

RuiSantos.ZocDoc.Core.Tests/MedicalSpecialtiesManagementTests.cs

@@ -14,7 +14,7 @@ namespace RuiSantos.ZocDoc.Core.Tests;
 public class MedicalSpecialtiesManagementTests
 {
     private readonly Mock<IDataContext> mockDataContext = new();
-    private readonly Mock<ILogger<MedicalSpecialtiesManagement>> mockLogger = new(  );
+    private readonly Mock<ILogger<MedicalSpecialtiesManagement>> mockLogger = new();
 
     [Fact]
     public async Task CreateMedicalSpecialtiesAsync_WithValidInput_ShouldStoreMedicalSpecialties()

RuiSantos.ZocDoc.Core/Data/IDataContext.cs

@@ -3,7 +3,7 @@
 namespace RuiSantos.ZocDoc.Core.Data;
 
 public interface IDataContext
-	{
+{
     Task<bool> ExistsAsync<TModel>(Expression<Func<TModel, bool>> expression);
     Task<TModel?> FindAsync<TModel>(Guid id);
     Task<TModel?> FindAsync<TModel>(Expression<Func<TModel, bool>> expression);

RuiSantos.ZocDoc.Core/Managers/AppointmentManagement.cs

@@ -83,6 +83,10 @@ public async Task DeleteAppointmentAsync(string socialNumber, string medicalLice
             if (doctor.Appointments.RemoveAll(app => app.Id == appointment.Id) > 0)
                 await context.StoreAsync(doctor);
         }
+        catch (ValidationFailException)
+        {
+            throw;
+        }
         catch (Exception ex)
         {
             logger?.LogException(nameof(AppointmentManagement), nameof(DeleteAppointmentAsync), ex);

RuiSantos.ZocDoc.Core/Models/Appointment.cs

@@ -4,8 +4,8 @@ public class Appointment
 {
     public Guid Id { get; }
     public DayOfWeek Week { get; set; }
-    public DateOnly Date { get; set;  }
-    public TimeSpan Time { get; set;  }
+    public DateOnly Date { get; set; }
+    public TimeSpan Time { get; set; }
 
     public Appointment()
     {

RuiSantos.ZocDoc.Core/Models/MedicalSpeciality.cs

@@ -5,16 +5,16 @@ public class MedicalSpeciality
     public Guid Id { get; }
     public string Description { get; set; }
 
-	public MedicalSpeciality()
-	{
-		this.Id = Guid.NewGuid();
-		this.Description = String.Empty;
-	}
+    public MedicalSpeciality()
+    {
+        Id = Guid.NewGuid();
+        Description = String.Empty;
+    }
 
-	public MedicalSpeciality(string description)
-	{
-        this.Id = Guid.NewGuid();
-        this.Description = description;
-	}
+    public MedicalSpeciality(string description)
+    {
+        Id = Guid.NewGuid();
+        Description = description;
+    }
 }
 

RuiSantos.ZocDoc.Core/Models/OfficeHour.cs

@@ -7,8 +7,8 @@ public class OfficeHour
 
     public OfficeHour()
     {
-        this.Week = DayOfWeek.Monday;
-        this.Hours = Enumerable.Empty<TimeSpan>();
+        Week = DayOfWeek.Monday;
+        Hours = Enumerable.Empty<TimeSpan>();
     }
 
     public OfficeHour(DayOfWeek week, IEnumerable<TimeSpan> hours)

RuiSantos.ZocDoc.Core/Models/Person.cs

@@ -2,18 +2,18 @@
 
 public class Person
 {
-	public string Email { get; set; }
-	public string FirstName { get; set; }
-	public string LastName { get; set; }
-	public IEnumerable<string> ContactNumbers { get; set; }
+    public string Email { get; set; }
+    public string FirstName { get; set; }
+    public string LastName { get; set; }
+    public IEnumerable<string> ContactNumbers { get; set; }
 
-	public Person()
-	{
-		this.FirstName = string.Empty;
-		this.LastName = string.Empty;
-		this.Email = string.Empty;
-		this.ContactNumbers = Enumerable.Empty<string>();
-	}
+    public Person()
+    {
+        FirstName = string.Empty;
+        LastName = string.Empty;
+        Email = string.Empty;
+        ContactNumbers = Enumerable.Empty<string>();
+    }
 
     public Person(string email, string firstName, string lastName, IEnumerable<string> contactNumbers)
     {

RuiSantos.ZocDoc.Data.Mongodb/MongoContext.cs

@@ -14,7 +14,7 @@ public MongoContext(string connectionString)
     {
         var mongoUrl = MongoUrl.Create(connectionString);
         var client = new MongoClient(mongoUrl);
-        this.database = client.GetDatabase(mongoUrl.DatabaseName);
+        database = client.GetDatabase(mongoUrl.DatabaseName);
 
         Mediator.RegisterClassMaps();
     }