Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fix sonar issues in various components #4017

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

koladilip
Copy link
Contributor

What are the changes introduced in this PR?

Mostly small fixes

What is the related Linear task?

Resolves INT-2990

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@koladilip koladilip requested review from a team and sivashanmukh as code owners January 25, 2025 13:28
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

Copy link

codecov bot commented Jan 25, 2025

Codecov Report

Attention: Patch coverage is 96.77419% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.82%. Comparing base (2f7be73) to head (37a9d8f).
Report is 12 commits behind head on develop.

Files with missing lines Patch % Lines
...destinations/fb_custom_audience/recordTransform.js 96.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4017      +/-   ##
===========================================
- Coverage    90.84%   90.82%   -0.02%     
===========================================
  Files          626      627       +1     
  Lines        32683    32691       +8     
  Branches      7759     7761       +2     
===========================================
+ Hits         29690    29693       +3     
+ Misses        2770     2743      -27     
- Partials       223      255      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants