Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixing wrong identifiers in payload for twitter ads destination #3988

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

manish339k
Copy link
Contributor

What are the changes introduced in this PR?

x expects IP address is required to be passed in conjunction with another identifier (twclid, email address, phone number or user agent). and User Agent is required to be passed in conjunction with another identifier (twclid, email address, phone number or IP address).
ref: https://developer.x.com/en/docs/x-ads-api/measurement/web-conversions/api-reference/conversions
Previously implementation was wrong due to which we were getting error while sending the events with ip_address or/and user_agent. This PR fixes this issue.

What is the related Linear task?

Resolves INT-3052

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@manish339k manish339k requested review from a team and sivashanmukh as code owners January 17, 2025 11:59
@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.77%. Comparing base (eacfdf1) to head (40e41b7).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3988   +/-   ##
========================================
  Coverage    90.77%   90.77%           
========================================
  Files          624      624           
  Lines        32551    32556    +5     
  Branches      7726     7730    +4     
========================================
+ Hits         29547    29552    +5     
  Misses        2748     2748           
  Partials       256      256           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

if (ipAddress) {
identifiers.push({ ip_address: ipAddress });
identifiers[0] = { ...identifiers[0], ip_address: ipAddress };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

identifiers[0].ip_address = ipAddress;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krishna2020 this could have been done with Feature flags
cc: @vinayteki95 @dhawal-rudder

if (userAgent) {
identifiers.push({ user_agent: userAgent });
identifiers[0] = { ...identifiers[0], user_agent: userAgent };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

identifiers[0].user_agent = userAgent;

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

@devops-github-rudderstack
Copy link
Contributor

Allure Test reports for this run are available at:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants