Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodev16 to run playwright correct installation #24

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Conversation

egazzarr
Copy link
Contributor

@egazzarr egazzarr commented Oct 13, 2023

The test workflow was failing as there was a change in the node code that was by default using a newer version (v16), which required a new package to be installed (playwright).

@egazzarr egazzarr mentioned this pull request Oct 13, 2023
Copy link
Contributor

@garciagenrique garciagenrique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.
If this PR is merged, #23 should be closed, as tried to do the same.

@egazzarr egazzarr merged commit ef1de55 into master Oct 13, 2023
1 check passed
@egazzarr egazzarr deleted the fix_test_workflow branch October 13, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants