fix(app):replace Unapprove with Disapprove

[ferbsx]

fixes #86

[joecorcoran]

We talked about this briefly last night. I think there's still an issue, in that the word "disapproved" means that something has been actively chosen as unacceptable. In our case, everything in the approved = false category is just passively categorised as such, by default.

Both "unapproved" (not strictly a real word, but useful) and "disapproved" don't really work. I would change the wording in the UI to "Approved events / Non-approved events" or if you don't like that, simply "Approved events / Other events". In the code (scopes etc.) it doesn't matter that much, as long as we all know what we're talking about.

But let's not worry about this too much :)

"The map is not the territory" — Alfred Korzybski

[fidothe]

oh man, I just commented on the issue. Sorry for the pile-on, @ferbsx.

[joecorcoran]

Grammar party! 🎉

[ferbsx]

I know! Unapproved is grammatically wrong but disapproved isn't the right word either! So taking your suggestions into account, I think "Approved events / Non-approved events" is the best option.

[fidothe]

Unapproved is a real word whose meaning is exactly what we want here (it's in the OED on your mac, thrill seekers). Unapprove would be a problem if you used it like disapprove, i.e. 'I unapprove of your new car', but using it in relation to "not officially accepted or sanctioned" is fine, i.e. 'I'm sorry but your permit shouldn't have been approved, so I'm going to have to unapprove it'.

[ferbsx]

Sorry, Unapprove^* is what I meant.

[ferbsx]

What do you suggest we do @fidothe ?

[fidothe]

If you're super keen to avoid 'Unapprove' I suggest the action becomes 'Reject'. And then I think we should all have a nice cup of tea and a piece of cake. Mmmmm, cake.

[lisbethmarianne]

"Reject" sounds really wrong to me. Because also newly submitted events are "unapproved".

[fidothe]

Wah, no cake for me...

New events submitted unapproved, which means the only action available is to approve them. They can only be rejected after they've been approved. Does that help at all?

(I think the list of unapproved events should be called 'unapproved' and definitely not 'rejected')

[ariaru]

Joe suggested "non-approved" for the user interface. I'd vote for that 👍
Everything else could stay as it is now, yay!
😄

[ariaru]

🍰 for Matt!

[ariaru]

Ah, yes, the action. We could also talk about this again (briefly) next week and decide then, it shouldn't be too hard by now?

[thatbettina]

What about 'waiting for human approval'?

Sent from my iPhone

On Dec 1, 2015, at 12:44, ariaru [email protected] wrote:

Ah, yes, the action. We could also talk about this again (briefly) next week and decide then, it shouldn't be too hard by now?

—
Reply to this email directly or view it on GitHub.

[langjoh]

See issue #86