Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mini_racer converts JS objects to Ruby objects. Ruby's C API functions call rb_raise() on invalid inputs, and rb_raise() in turn is a glorified longjmp() that jumps up the stack.
Longjmp and C++ destructors do not play well together. It left V8 in an undefined state, resulting in random "Disposing the isolate that is entered by a thread" fatal errors.
Fixes: #316
Easiest to review with
?w=1
(link), the bulk is whitespace change because of an extra level of indent.The title says "invalid date object" but this pull request in fact addresses a wider range of bugs around value conversion.
There is at least one other instance around JSON parsing. I'll open another PR for that.