Refactor system tests to pass in DevContainers #5271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5271 +/- ##
=======================================
Coverage 96.88% 96.88%
=======================================
Files 457 457
Lines 9576 9576
=======================================
Hits 9278 9278
Misses 298 298 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
simi
reviewed
Nov 23, 2024
| @@ -16,7 +16,7 @@ class ApiKeysTest < ApplicationSystemTestCase | |||
|
|
|||
| assert_nil URI.parse(page.current_url).query | |||
|
|
|||
| fill_in "api_key[name]", with: "test" | |||
| fill_in "api_key[name]", with: "test-api-key" | |||
There was a problem hiding this comment.
Is this (and other similar changes in testing) related to dev containers?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this about?
I'm currently on a quest to lift up our much aging test suite to one that aligns well to today's standards. The first step for me is to get the current test suit passing. I personally use DevContainers for my development, so I needed to make some configuration changes and move some system tests from
rack-testto Capybara/Selenium.The biggest change in this PR is namely the codebase assuming everything is running on
localhost. I needed to make changes to our tests use the correct URL when inside a DevContainer.