-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 1293: Add a card for mobile #1295
base: main
Are you sure you want to change the base?
Issue 1293: Add a card for mobile #1295
Conversation
Side note: I tried testing what this would look like with multiple foster records and I ran into some database confusion. I created another instance of However, when I tried to render it never showed up. When I printed the number of matches in the view file upon rendering, it only ever showed the original match, even after manually calling Not sure if I'm missing something there but that's why you only see one card in the demo. |
@jasonwang7517 I'd have to look at the logic but it sounds like you tried to create it via the console? You should be able to create a new forster at This is the applications tab referenced in the issue. Can you try to do something similar? There might be a partial in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh nice you did this without having separate markup for mobile that is hidden. This is better for sure. This is what you were referring to @jmilljr24 ?
@@ -1,24 +1,24 @@ | |||
<div id="fosters_tab_table" class="card"> | |||
<div id="fosters_tab_table" class="card col-6 col-xl-12"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this will be a full width table above 1200px right? Then below this it will collapse into half width and flex will place items accordingly (referring to the use of flex-xl-row
below).
I am curious how this looks as you drag screen width from 1200+px down. I imagine that we will show the row above 1200px then show 'cards' below 1200px. In my mind, there's a lot of possible devices (tablets or horizontal cell) that might do fine with a table row below 1200px? So XL might be a bit of a large breakpoint? Do you think we can set this breakpoint at Lg or even Md?
@kasugaijin Yes, however I'm not sure this hits the mark are far as ui/ux goes. I think for the time being I would use the design we already have using separate markup for desktop and mobile. This keeps a consistent look and feel until we think more about a design for the person profile page. If we can get something the checks the box for a single markup response design on the person profile page, we could then circle back to the pets page. |
Yeah I have to agree with this. @jasonwang7517 could you please see how we implement this for other pages. We actually render two sets of 'duplicate' markup, and hide one depending on the screen width. In this case, you need to add the markup that will show on smaller screens. See existing implementations for breakpoints and card layouts. |
🔗 Issue
Original issue
✍️ Description
Adds responsive sizing for the fosters tab for smaller displays.
📷 Screenshots/Demos
Screen.Recording.2024-12-20.at.7.11.37.PM.mov