Refactor countries states (#1278)

* Refactor countries states to use full name module because the CS module name was breaking in the Org settings context (might interfere with an existing name)

* lint fixes

* update test

app/controllers/country_states_controller.rb → app/controllers/countries_states_controller.rb

@@ -1,4 +1,4 @@
-class CountryStatesController < ApplicationController
+class CountriesStatesController < ApplicationController
   skip_before_action :authenticate_user!
   skip_verify_authorized only: %i[index]
 
@@ -8,7 +8,7 @@ def index
     @name = params[:name]
     @selected_state = params[:province_state]
 
-    @states = CS[country.to_sym][:states].invert
+    @states = COUNTRIES_STATES[country.to_sym][:states].invert
 
     respond_to do |format|
       format.turbo_stream

app/controllers/organizations/staff/organizations_controller.rb

@@ -6,6 +6,7 @@ class OrganizationsController < Organizations::BaseController
       before_action :set_organization, only: %i[edit update]
 
       def edit
+        @location = @organization.locations.last || @organization.locations.build # polymorphic
       end
 
       def update

app/views/organizations/staff/organizations/_form.html.erb

@@ -39,9 +39,8 @@
       <div class="col-lg-6">
 
         <!-- Nested Form for Locations Table -->
-        <div class="form-group bigger" data-controller="country-state">
-          <% location = organization.locations.last || organization.locations.build %>
-          <%= form.fields_for :locations, location do |location_form| %>
+        <div class="form-group" data-controller="country-state">
+          <%= form.fields_for :locations, @location do |location_form| %>
             <%= render 'shared/location_fields', form: location_form %>
           <% end %>
         </div>

app/views/shared/_location_fields.html.erb

@@ -1,9 +1,9 @@
 <!-- Country Select -->
 <%= form.select :country,
-                CS.keys.index_with { |abbr| CS.dig(abbr, :name) }.invert,
+                COUNTRIES_STATES.keys.index_with { |abbr| COUNTRIES_STATES.dig(abbr, :name) }.invert,
                 { prompt: "Please select" },
                 {
-                  'data-path': country_states_path,
+                  'data-path': countries_states_path,
                   'data-country-state-target': 'country',
                   'data-action': 'change->country-state#updateStates',
                   required: true,
@@ -12,7 +12,7 @@
 <!-- Province/State Select -->
 <%= form.select :province_state,
                 form.object.country.present? ? 
-                CS.dig(form.object.country.to_sym, :states)&.map { |abbr, name| [:name, abbr] } : [],
+                COUNTRIES_STATES.dig(form.object.country.to_sym, :states)&.map { |abbr, name| [:name, abbr] } : [],
                 { prompt: "Please select" },
                 {
                   'data-country-state-target': 'state',

config/initializers/countries_states.rb

@@ -1,6 +1,6 @@
 begin
-  CS = YAML.safe_load_file(Rails.root.join("config/countries_states.yml"), symbolize_names: true).freeze
+  COUNTRIES_STATES = YAML.safe_load_file(Rails.root.join("config/countries_states.yml"), symbolize_names: true).freeze
 rescue => e
   puts "Error loading countries_states.yml: #{e.message}"
-  CS = {}.freeze
+  COUNTRIES_STATES = {}.freeze
 end

config/routes.rb

@@ -9,7 +9,7 @@
   }
 
   # Application Scope
-  resources :country_states, only: [:index]
+  resources :countries_states, only: [:index]
 
   root "root#index"
   get "/up", to: "root#up" # Health check endpoint to let Kamal know the app is up

test/controllers/country_states_controller_test.rb

@@ -1,14 +1,14 @@
 require "test_helper"
 
-class CountryStatesControllerTest < ActionDispatch::IntegrationTest
+class CountriesStatesControllerTest < ActionDispatch::IntegrationTest
   test "should return turbo stream with the states in it" do
     adopter = create(:adopter)
     sign_in adopter
 
     name = "adopter[address_attributes][state]"
     target = "adopter_foster_profile_location_attributes_province_state"
 
-    get country_states_path,
+    get countries_states_path,
       headers: {"Accept" => "text/vnd.turbo-stream.html"},
       params: {country: "CA", target:, name:, province_state: "BC"}