Skip to content

Commit

Permalink
1143 make section content larger (#1147)
Browse files Browse the repository at this point in the history
* Add refactor: Changed the test as directed in the issue from its original strings to the newer ones. The change can be found in the config/locales/en.yml file lines 111-116.

* Add refactor: added in the fs- bootstrap utilities to all three of the h4 classes for the titles in the section to increase their size/readability. I personally think it's too large and would like to set it to 1.5 rem, but the utilities are limited. All three are currently at 2.5rem font size. The paragraphs have not been changed, staying at their default value of what I believe is 0.875rem. This is due to the fact that fs-5 sets it to the same size, but fs-4 sets it to 1rem which makes the paragraphs be at two lines instead of one for the longer paragraphs. A solution could be to create a custom class in custom.scss Along the lines of .custom-fs-4-f with the a desired font-size of around 0.9rem or so. But I am staying away from doing so due to the message in custom.scss asking us to stick to the provided bootstrap utilities. Similarly the same issue for the h4 elements.

* Add refactor: Changed the config/locales/en.yml keys on lines 115 & 116 to save_time and save_time_description respectively and also changed the calls for them in app/views/root/index.html.erb on lines 54 & 55 to better reflect their content due changing it from personalized as instructed in the issue.
  • Loading branch information
Isaac3924 authored Nov 17, 2024
1 parent 3de5d2c commit 18415cd
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions app/views/root/index.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -35,24 +35,24 @@
<div class="col-xl-4 col-lg-4 col-md-6 mb-lg-0 mb-4">
<div class="d-flex justify-content-center align-items-center">
<div class="ms-3">
<h4 class="mb-0 fw-semibold text-center text-dark"><%= t('.free')%></h4>
<h4 class="mb-0 fw-semibold text-center text-dark fs-2"><%= t('.free')%></h4>
<p class="mb-0 text-center" style = "color: #373737;"><%= t('.free_description')%></p>
</div>
</div>
</div>
<div class="col-xl-4 col-lg-4 col-md-6 mb-lg-0 mb-4">
<div class="d-flex justify-content-center align-items-center">
<div class="ms-3">
<h4 class="mb-0 fw-semibold text-center text-dark"><%= t('.easy')%></h4>
<h4 class="mb-0 fw-semibold text-center text-dark fs-2"><%= t('.easy')%></h4>
<p class="mb-0 text-center" style = "color: #373737;"><%= t('.easy_description')%></p>
</div>
</div>
</div>
<div class="col-xl-4 col-lg-4 col-md-6 mb-lg-0 mb-4">
<div class="d-flex justify-content-center align-items-center">
<div class="ms-3">
<h4 class="mb-0 fw-semibold text-center text-dark"><%= t('.personalized')%></h4>
<p class="mb-0 text-center" style = "color: #373737;"><%= t('.personalized_description')%></p>
<h4 class="mb-0 fw-semibold text-center text-dark fs-2"><%= t('.save_time')%></h4>
<p class="mb-0 text-center" style = "color: #373737;"><%= t('.save_time_description')%></p>
</div>
</div>
</div>
Expand Down
8 changes: 4 additions & 4 deletions config/locales/en.yml
Original file line number Diff line number Diff line change
Expand Up @@ -113,11 +113,11 @@ en:
btn_subtitle: "Free for all rescues, forever."
img_sub: "Manage your operation with ease"
free: "Free"
free_description: "Use our app for your organization at no cost."
free_description: "Free for pet rescue organizations, forever."
easy: "Easy"
easy_description: "Manage staff profiles, tasks, adoption and foster scheduling in a single app."
personalized: "Personalized"
personalized_description: "Add default tasks, create your own forms, and more."
easy_description: "Get your own customizable website up and running instantly."
save_time: "Save Time"
save_time_description: "Manage pets, people, fosters, and adoptions on one platform."
website: 'A website that’s ready to go'
website_description: 'Have a public facing website up and running in minutes.'
keep_track: 'Keep track of your pets'
Expand Down

0 comments on commit 18415cd

Please sign in to comment.