Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
1143 make section content larger (#1147)
* Add refactor: Changed the test as directed in the issue from its original strings to the newer ones. The change can be found in the config/locales/en.yml file lines 111-116. * Add refactor: added in the fs- bootstrap utilities to all three of the h4 classes for the titles in the section to increase their size/readability. I personally think it's too large and would like to set it to 1.5 rem, but the utilities are limited. All three are currently at 2.5rem font size. The paragraphs have not been changed, staying at their default value of what I believe is 0.875rem. This is due to the fact that fs-5 sets it to the same size, but fs-4 sets it to 1rem which makes the paragraphs be at two lines instead of one for the longer paragraphs. A solution could be to create a custom class in custom.scss Along the lines of .custom-fs-4-f with the a desired font-size of around 0.9rem or so. But I am staying away from doing so due to the message in custom.scss asking us to stick to the provided bootstrap utilities. Similarly the same issue for the h4 elements. * Add refactor: Changed the config/locales/en.yml keys on lines 115 & 116 to save_time and save_time_description respectively and also changed the calls for them in app/views/root/index.html.erb on lines 54 & 55 to better reflect their content due changing it from personalized as instructed in the issue.
- Loading branch information