fix #95: error 'Could not compute content quads' #118
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @route,
sorry that it took so long. 😞
So the thing is: in theory
DOM.getContentQuads
is absolutely the right thing to do. But depending on the used browser, this seem to be unstable, though (and I'm sure it will change in the future).Thus, if we're running into this unstable state (and only then!) we're going to calculate the position via JS instead.
This might be slower, but at least it's working flawlessly. And hopefully
getContentQuads
will become more stable and we won't run into this anymore anyway.I hope it's working for you and others. At least it's working in the projects of my clients.
PS: We should definitely get rid of all the
sleep
s in the specs and migrate to a more stable solution. Maybe this would be related to #81 / #82 (I still don't know why you created another issue for this). 😉