Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #95: error 'Could not compute content quads' #118

Merged
merged 1 commit into from
Oct 8, 2020
Merged

fix #95: error 'Could not compute content quads' #118

merged 1 commit into from
Oct 8, 2020

Conversation

alexanderadam
Copy link
Contributor

@alexanderadam alexanderadam commented Oct 7, 2020

Hi @route,

sorry that it took so long. 😞

So the thing is: in theory DOM.getContentQuads is absolutely the right thing to do. But depending on the used browser, this seem to be unstable, though (and I'm sure it will change in the future).

Thus, if we're running into this unstable state (and only then!) we're going to calculate the position via JS instead.
This might be slower, but at least it's working flawlessly. And hopefully getContentQuads will become more stable and we won't run into this anymore anyway.

I hope it's working for you and others. At least it's working in the projects of my clients.

PS: We should definitely get rid of all the sleeps in the specs and migrate to a more stable solution. Maybe this would be related to #81 / #82 (I still don't know why you created another issue for this). 😉

@route route merged commit f1bd9c1 into rubycdp:master Oct 8, 2020
@route
Copy link
Member

route commented Oct 8, 2020

Thank you

@alexanderadam
Copy link
Contributor Author

I have to thank you buddy. 🙌
Thank you so much for the RubyCDP projects. I wish @crystal-lang would have libraries like these.

@alexanderadam alexanderadam deleted the bugfix/fix_computing_content_quads_error_95 branch October 8, 2020 09:48
@route
Copy link
Member

route commented Oct 8, 2020

Haha maybe some day :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants