Improve checks for actual duration in sleep specs #1213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `should <` instead of trying to match the boolean itself. This way,
the output on failures show the actual duration instead of just a
true/false error.
Example error message with this change:
Expected 0.15368436999779078 < 0.03
|
Let's close, it doesn't even pass reliably on Linux and the spec needs to be reworked |
|
Weirdly enough I did not think this worked. Thanks for the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
should <instead of trying to match the boolean itself. This way, the output on failures show the actual duration instead of just a true/false error.Example error message with this change:
Just happened to spot this in #1212. I'm leaving this as draft for now, to prevent it from clashing with those changes.