Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable sleep ns spec on MacOS #1212

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Reenable sleep ns spec on MacOS #1212

merged 2 commits into from
Nov 7, 2024

Commits on Nov 7, 2024

  1. Only test that sleeps were long enough 

    This spec was originally added to confirm that sub-millisecond
sleeps actually did sleep; on JRuby and TruffleRuby before fixes
a sleep of 0.0001s would immediately return, because we both used
a sleep function with a minimum resolution of 0.001s. Ideally 100
sleeps of 0.0001s should not exceed 0.03s, but since that's not
the goal of this spec and since it makes the spec flaky under load
or on slower systems, it seems best to remove this check.

The remaining check just confirms that 100x sleep of 0.0001s does
actually sleep for at least 0.01s. Any Ruby failing the spec now
would indicate they are not actually sleeping for 0.0001s and they
need a fix.
    @headius
    headius committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    252996c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into sleep_ns_spec_on_macos

    @headius
    headius authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    30c8932 View commit details
    Browse the repository at this point in the history