Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following issues are addressed:
Notes:
failure due to #format method not being implemented for given
class; so in these cases the fix boils down to implementing format.
sample code from the YARP definition (config.yml), with one exception:
the sample code for KeywordHashNode is 'foo(a: b)', but for that
expression the formatting code preempts winding down to the
KeywordHashNode instance, so the lack of KeywordHashNode#format is
not triggered. The expression given for KeywordHashNode does indeed
trigger KeywordHashNode#format. (Ironically, 'foo(a: b)' still had
a formatting issue, but for a different reason.)
"formatting failure" is indicated raise an exception with
SyntaxTree::Formatter.format; the other cases do return but with a
bogus result.
entries 2. to 4.) are shadowed by the first one (constant misnomer).
Without fixing the name these entries will also end up with an exception.
When the constant name is fixed, the indicated issue will be present.
Tested with YARP 0eb5f7c3..