Combine Elsif node with IfNode
#299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egiurleo
force-pushed
the
elsif
branch
3 times, most recently
from
312d110
to
22d2648
Compare
egiurleo
commented
Feb 8, 2023
egiurleo
force-pushed
the
elsif
branch
3 times, most recently
from
2a1a922
to
37c0a4d
Compare
|
Hey @kddnewton just gently bumping this. I'd love a review when you have time! |
kddnewton
requested changes
Feb 26, 2023
Many other Ruby ASTs do not have a separate node representing `elsif` conditionals; instead, they use the same node as `if` but make it a consequent of other `if` nodes. This commit removes the `Elsif` node and combines its functionality with `IfNode`, ensuring that both the parsing and formatting logic are still functional.
And add `beginning` kwarg to `IfNode` DSL method.
|
@kddnewton Thanks for the feedback! I think I've implemented all the changes you requested. The big ones were:
|
|
@egiurleo I ended up merging this into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #278. Completed with @bitwise-aiden.
This PR eliminates the
Elsifnode and folds its functionality intoIfNode. Now,elsifconditional statements will be represented withIfNodesthat are the consequent of anotherIfNode. This eliminates an unnecessary node type from syntax tree, simplifies a lot of logic, and brings syntax tree closer to other AST representations of Ruby.