Fully Support Styles #145
Merged
Fully Support Styles #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is system throughout the app.
|
Are we still trying to support Ruby 2.6 @satoryu? Thanks for reviewing and considering this change. |
|
@rickychilcott, thank you for opening this pull request! |
|
FYI: #146 |
|
Cool, thanks! I merged in master and added a bit more documentation! |
|
Hey @satoryu! We've now shipped a feature in our application using my fork, and it's working like a charm. Are you willing to review this to see if we could consider getting this merged in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement creating, removing, and editing existing document styles.
It's a massive PR. Sorry.
But it works and it's cool. So it's got that going for it.