add indent in document_spec, remove document API and pass document th…

…rough paragrah constructor
ruby-docx · Oct 14, 2023 · 8245e15 · 8245e15
1 parent 4e459b0
commit 8245e15
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 8 deletions.
diff --git a/lib/docx/containers/paragraph.rb b/lib/docx/containers/paragraph.rb
@@ -15,14 +15,11 @@ def self.tag
 
         # Child elements: pPr, r, fldSimple, hlink, subDoc
         # http://msdn.microsoft.com/en-us/library/office/ee364458(v=office.11).aspx
-        def initialize(node, document_properties = {})
+        def initialize(node, document_properties = {}, doc = nil)
           @node = node
           @properties_tag = 'pPr'
           @document_properties = document_properties
           @font_size = @document_properties[:font_size]
-        end
-
-        def document=(doc)
           @document = doc
         end
 

diff --git a/lib/docx/document.rb b/lib/docx/document.rb
@@ -210,9 +210,7 @@ def update
 
     # generate Elements::Containers::Paragraph from paragraph XML node
     def parse_paragraph_from(p_node)
-      p = Elements::Containers::Paragraph.new(p_node, document_properties)
-      p.document = self
-      p
+      Elements::Containers::Paragraph.new(p_node, document_properties, self)
     end
 
     # generate Elements::Bookmark from bookmark XML node

diff --git a/spec/docx/document_spec.rb b/spec/docx/document_spec.rb
@@ -507,7 +507,7 @@
 
   describe 'reading style' do
     before do
-    @doc = Docx::Document.open(@fixtures_path + '/test_with_style.docx')
+      @doc = Docx::Document.open(@fixtures_path + '/test_with_style.docx')
     end
 
     it 'read default style when not' do