Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue with mnemonickey reading #175

Merged
merged 1 commit into from
Jun 7, 2024
Merged

issue with mnemonickey reading #175

merged 1 commit into from
Jun 7, 2024

Conversation

thewebchap
Copy link
Member

Following #174 , there was an issue reading mnemonickeyfile . This PR fixes it.

maneeSHA-256
maneeSHA-256 approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@maneeSHA-256 maneeSHA-256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test cases:

  1. mnemonic key file not passed
  2. wrong mnemonic key file path
  3. mnemonic key passed & did is as expected
    Screenshot from 2024-06-07 14-21-25

@thewebchap thewebchap merged commit 805d02b into development Jun 7, 2024
3 checks passed
@thewebchap thewebchap deleted the hari/mnemonicfile-check branch August 5, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maneeSHA-256 maneeSHA-256 maneeSHA-256 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thewebchap @maneeSHA-256