Ping Peer Improvement #154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating main branch
handling non connected peer in Pincheck
Gklps/pingcheckfix
Development
Merging development to main
Add `release` Github Action workflow
Merging development to Main
Add feature: Alternate quorum selection
merging development to main
Merge pull request #148 from rubixchain/ft/quorum-setup-check
bump rubixgoplatform version to 0.0.17 for release
…t-fix Added `dist/` in `.gitignore` to fix merge conflict with `main` branch
`.gitignore` merge conflict fix
Release: v0.0.17
…flow-files hotfix: adding release github action files which were removed while merging PR #151
Syncing `development` and `main` branch
…block-with-signVersion Adding sender signature details in block
…atform into maneesha/PingPeerImprovement
maneeSHA-256
force-pushed
the
maneesha/PingPeerImprovement
branch
from
7518823
to
8fea0d4
Compare
maneeSHA-256
changed the base branch from
development
to
ashita/adding-peer-details
…chain/rubixgoplatform into maneesha/PingPeerImprovement
… info with quorums
|
Closing this PR. Please refer to the PR #176 for updates related to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were connecting a peer, say Alice is connecting Bob, to check
peer statusor to fetch it'sDIDTypefor token ownership validation. In this branch the protocol is being improved. Now Alice can share herPeerId,DIDandDIDTypethrough the same API which she was using for fetching Bob'sstatusorDIDType. Bob will register or update Alice's details inDIDPeerTableif not already registered or needs to be updated.This branch has been tested with the following test cases:
sender & reciever's quorums: Q1-Q5
receiver doesn't have sender details
Result : successful
sender doesn't have receiver did type and receiver doesn't have sender details
Result : receiver gets sender details but sender doesn't get receiver did type [as expected]
receiver doesn't have sender did type
Result : successful
receiver doesn't have sender correct peerID
Result : successful
receiver doesn't have sender peerID
Result : successful
receiver doesn't have sender peerID and did type
Result : successful
quorums doesn't have sender details :
Q1 : doesn't have sender details
Q2 : doesn't have sender details and sender doesn't have Q2 did type
Q3 : doesn't have sender did type
Q4 : doesn't have sender peerID and did type
Q5 : doesn't have sender correct peerID
Result : successful
prev pledged quorum (Q4) doesn't have quorum details
sender : doesn't have Q4 did type
Q1: doesn't have Q4 did type
Q3: doesn't have Q4 did type
Q4 : doesn't have sender details , Q1 details, Q2 details, Q3 did type & correct peerID, Q5 peerID
Result: couldn't retrieve Q2 & Q5 [as expected]
sender's quorums: Q2-Q6 ; reciever quorums: Q1-Q5
prev pledged quorum (Q1) doesn't have sender details
Q2: peerID of Q1
Q4: didtype & peerID of Q1
Q6: did type of Q1
Sender: did type of Q1
Q1: doesn't have sender details , Q2 details, Q4 did type & correct peerID, Q6 peerID
Result: failed as Q4 doesn't have peerID of Q1 to ping & fetch its did type [as expected]
prev pledged quorum (Q1) doesn't have sender details
Q2: peerID of Q1
Q4: didtype of Q1
Q6: did type of Q1
Sender: did type of Q1
Q1: doesn't have sender details , Q2 details, Q4 did type & correct peerID, Q6 peerID
Result: couldn't retrieve Q2 & sender details [as expected]
sender creates new token
Q2 : doesn't have sender did type
Q6 : doesn't have sender did type
sender : doesn't have Q2 did type & Q6 details
Result : successful
Test Cases for the commit -
997366a73860e1ed22ce1148eca605f38ba9c54c:Sender's Qrms: Q4-Q8 ; Receiver's Qrms: Q11-Q15
Sender added peer details of Q4-Q8; Receiver added peer details of Q11-Q15; Sender added peer details of Receiver
Transfer 1 RBT from Sender to Receiver :
Result: [transfer successful]
Q7: pledged-quorum
Receiver: have peer details of Q4-Q8 & Sender in DIDPeerTable
Q4-Q8: have peer details of Sender in DIDPeerTable
Transfer 1 RBT from Receiver to Sender:
Result: [transfer successful]
Q15: pledged-quorum
Sender: have peer details of Receiver & Q11-Q15 in DIDPeerTable
Q11-Q15: have peer details of Receiver & Q7(prev pledged quorum) in DIDPeerTable
Transfer 1 RBT from Sender to Receiver :
Result: [transfer successful]
Q5: pledged-quorum
Q4-Q8: have peer details of Q15(prev pledged quorum) in DIDPeerTable