Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix unit error on ELM output and CLASS data std uncertainty #114

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix unit error on ELM output and CLASS data std uncertainty #114

wants to merge 2 commits into from

Conversation

minxu74
Copy link
Contributor

@minxu74 minxu74 commented Dec 16, 2024 •
edited
Loading

  • Replaced the unit of "proportion" from ELM output to CF units compatible unit "1"
  • Added a piece of code to test if the uncertainty provided by benchmark data is the upper and lower bounds of the data as assumed by ILAMB. If not, the uncertainty is assumed to be the std of the data, and the lower and upper bounds are set by its one std.

Fixes: #112 and #109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLASS data data_bnds (uncertainties) are not compatible to the ILAMB code
1 participant
@minxu74