Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type context #116

Merged
merged 5 commits into from
Sep 19, 2023
Merged

Conversation

jeswr
Copy link
Contributor

@jeswr jeswr commented Sep 19, 2023

Fixes #115 by deferring addition to the typeJobs queue until after the contextJobs have completed and then unaliasing the keywords.

@jeswr jeswr changed the title Chore/fix type context fix: type context Sep 19, 2023
@jeswr jeswr marked this pull request as draft September 19, 2023 10:24
@jeswr jeswr marked this pull request as ready for review September 19, 2023 10:25
Copy link
Owner

@rubensworks rubensworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Looks like that fixes it.

lib/JsonLdParser.ts Show resolved Hide resolved
@jeswr jeswr requested a review from rubensworks September 19, 2023 11:12
@rubensworks rubensworks merged commit 3249687 into rubensworks:master Sep 19, 2023
@rubensworks
Copy link
Owner

Thanks @jeswr! Released as 3.2.1.

@jeswr jeswr deleted the chore/fix-type-context branch September 22, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Type specific contexts not used when @type is aliased.
2 participants