This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
Update memo struct to use additional structure as memo item instead of embedded structure #77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the previous embedded struct, it was convenient if you read the transaction, but if not convenient if you create a transaction with the memo.
Previous ways of creating a memo:
The proposed changes are not breaking for
example 1
andexample 2
, but breaking forexample 3
which is rare in terms of usage in general. Anyway IMHO, better practice to have a commonMemoItem
.