Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #257 #328

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for issue #257 #328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion admin/class-purger.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,11 @@ protected function do_remote_get( $url ) {
*/
do_action( 'rt_nginx_helper_before_remote_purge_url', $url );

$response = wp_remote_get( $url );
$request_args = array(
'blocking' => false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing this will break the logging functionality and any actions that other plugins are performing on the hook rt_nginx_helper_after_remote_purge_url since a non blocking request initially starts with status 0, meaning the request is still processing, instead of actual status code like 200 or 404.

'sslverify' => false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be a security issue and sslverify should not be set to false at all unless you're testing things locally.

);
$response = wp_remote_get( $url, $request_args );

if ( is_wp_error( $response ) ) {

Expand Down