Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: Login redirection to Homepage instead of admin dashboard #177

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Update: Login redirection to Homepage instead of admin dashboard #177

wants to merge 2 commits into from

Conversation

SH4LIN
Copy link

@SH4LIN SH4LIN commented May 29, 2024

Description

  • This PR will replace the redirect URL to home_url() if redirect_to query argument is empty.

Technical Implementation

  • Replaced the admin_url() with home_url() from the Login.php and OneTapLogin.php

Fixes/Covers

@SH4LIN SH4LIN changed the title Update: Login redirection to Homepage instead of Admin dashboard Update: Login redirection to Homepage instead of admin dashboard May 29, 2024
Pathan-Amaankhan
Pathan-Amaankhan approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@Pathan-Amaankhan Pathan-Amaankhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joelabreo227 joelabreo227 mentioned this pull request Jul 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pathan-Amaankhan Pathan-Amaankhan Pathan-Amaankhan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SH4LIN @Pathan-Amaankhan