Merge pull request ampproject#7719 from ampproject/bump/node

Bump Nodejs; Fix PHPStan and PHPUnit failures
rtCamp · Mar 14, 2024 · ecb3124 · ecb3124
2 parents 2efb5c8 + 1a909d3
commit ecb3124
Show file tree

Hide file tree

Showing 12 changed files with 2,171 additions and 2,080 deletions.
diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-18
+20
diff --git a/assets/src/components/clipboard-button/test/__snapshots__/index.js.snap b/assets/src/components/clipboard-button/test/__snapshots__/index.js.snap
diff --git a/assets/src/components/error-screen/test/__snapshots__/index.js.snap b/assets/src/components/error-screen/test/__snapshots__/index.js.snap
diff --git a/assets/src/components/template-mode-option/test/__snapshots__/index.js.snap b/assets/src/components/template-mode-option/test/__snapshots__/index.js.snap
diff --git a/assets/src/onboarding-wizard/components/nav/test/__snapshots__/index.js.snap b/assets/src/onboarding-wizard/components/nav/test/__snapshots__/index.js.snap
diff --git a/includes/embeds/class-amp-tiktok-embed-handler.php b/includes/embeds/class-amp-tiktok-embed-handler.php
@@ -93,6 +93,8 @@ protected function make_embed_amp_compatible( Element $blockquote ) {
 
 		$blockquote->parentNode->replaceChild( $amp_tiktok, $blockquote );
 		$amp_tiktok->appendChild( $blockquote );
+
+		/** @var DOMDocument $dom */
 		$blockquote->setAttributeNode( $dom->createAttribute( Attribute::PLACEHOLDER ) );
 		$blockquote->removeAttribute( Attribute::STYLE );
 	}