Remove ellipsis dependency and use rlang #112
Conversation
olivroy
changed the title
olivroy
changed the title
R/sortable-package.R
Outdated
| #' @keywords internal | ||
| "_PACKAGE" | ||
|
|
||
|
|
||
| # The following block is used by usethis to automatically manage | ||
| # roxygen namespace tags. Modify with care! | ||
| ## usethis namespace: start | ||
| #' @importFrom assertthat assert_that is.string |
There was a problem hiding this comment.
Is there a reason that you moved these lines into the roxygen protected area?
NAMESPACE
Outdated
| @@ -19,6 +19,7 @@ export(sortable_js_capture_input) | |||
| export(sortable_options) | |||
| export(sortable_output) | |||
| export(update_bucket_list) | |||
| export(update_rank_list) | |||
There was a problem hiding this comment.
The function update_rank_list() is deliberately not exported because it doesn't accurately solve the problem it's supposed to solve.
|
Just undid the other unrelated changes! |
olivroy
changed the title
|
|
|
Hmmm. I'm not sure what happened, but the current status of this PR seems to not include the original change to use I'm almost done implementing your original intent into the Once that's done, I'll close this PR. Many thanks for identifying the deprecated code and suggesting the fix. |
olivroy
changed the title
|
Many thanks for your help. I'll revert from |
Done!
Since ellipsis is deprecated and replaced by equivalent rlang functions https://rlang.r-lib.org/news/index.html#argument-intake-1-0-0