align shinydashboard tab data-value with shiny tabs #390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess you'd probably want to update the codebase to use
bslib
, but since that is a lot of work updating shiny dashboard tabs to include adata-value
will allow other shiny related packages (like mine) to work with tabs across shiny and shiny dashboard in a generic way (see https://github.com/carlganz/rintrojs/blob/master/inst/javascript/rintro.js#L48)