add scroll option to box #311
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows for users to create a scroll-able box if they specify the height. The scroll bar is created if height is defined and scroll = TRUE and scrolling is enabled if the height of the content exceeds the height of the box.
While the scroll bar can be added manually to the
boxclass in a css file, it can only be added to all boxes as a result. Users are unable to change or add to the class of the topdivin theboxoutput. Specifying the class argument in theboxfunction appends to the class of the innerdivwhich does not look as good for the scroll bar. This function will add the style and the class to the topdivif the height is specified also.I looked at adding it to
tabBoxfor consistency but it seems more practical to allow to the user to just define the class and/or style totabPanelas setting class or style in that function access the top div of the tab.If there is anything else I should do to help get this merged, please let me know!
Thanks!