Updates #199
Merged
Updates #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bborgesr
force-pushed
the
barbara/changes
branch
4 times, most recently
from
be2fa71
to
25725a6
Compare
|
Closes #38. |
wch
reviewed
Apr 26, 2017
NEWS.md
Outdated
|
|
||
| * Split JS files. (commit [#ea91503](https://github.com/rstudio/shinydashboard/pull/199/commits/ea915038ae2126f48c15e3aac41782a22b16c506)). More updates to Gruntfile and structure. (commit [#4e80616](https://github.com/rstudio/shinydashboard/pull/199/commits/4e80616c5b3aa0dc73022dc815288b5ba7c35be0)) | ||
|
|
||
| * Added `findAttribute()` function. (commit [#97b952f](https://github.com/rstudio/shinydashboard/pull/199/commits/97b952f13fc5e6781895d49c40e865d4719cb86a)) |
There was a problem hiding this comment.
I don't think you need to mention this, since it's not exported.
wch
reviewed
Apr 26, 2017
NEWS.md
Outdated
|
|
||
| ### New features | ||
|
|
||
| * Address [#179](https://github.com/rstudio/shinydashboard/issues/179) support for bookmarking the expanded/collapsed state of the whole sidebar. (commit [#e71c93f](https://github.com/rstudio/shinydashboard/pull/199/commits/e71c93fa7a71f229e725efd4a7867e431cd57679)) |
There was a problem hiding this comment.
For commits, you don't need the #, so instead of #e71c93f, it would be e71c93f.
wch
reviewed
Apr 26, 2017
srcjs/AdminLTE/README-shiny-mods.md
Outdated
| @@ -3,3 +3,14 @@ This branch of AdminLTE contains the following changes from the stock version, t | |||
| * The box collapse function triggers 'shown' and 'hidden' events, so that Shiny knows when outputs are visible or not. See https://github.com/rstudio/shinydashboard/issues/42 for a test app (must re-apply commit 73f6027 when updating to newer version of Admin LTE). | |||
|
|
|||
| * In AdminLTE.css, the fonts are fetched from the local host, instead of from Google fonts (must re-apply commits e9e63d1 and 9ccb12d when updating to newer version of Admin LTE). | |||
|
|
|||
| * Add the following code chunk to app.js (see commit #???): | |||
There was a problem hiding this comment.
Does this need to be updated with a ref to the correct commit?
|
Other than the small things I commented on, this looks good. |
This was referenced Apr 27, 2017
Closed
…ed (if any), which makes bookmarking the exact state of the sidebar trivial. * Better shown/hidden mechanic for Shiny inputs inside collapsible menuItems.
…css transitions look reasonable when its content is initially empty (use case is for hidden Shiny outputs that are not rendered until the first time the menuItem is expanded and reveal them -- i.e. first time that trigger("shown") is called)
…appen on the sidebar
…d animation when `disable = TRUE` inside dashboardSidebar()
wch
reviewed
May 16, 2017
R/dashboardSidebar.R
Outdated
| # sidebar was collapsed. If this is not the case, the default is whatever the user | ||
| # specified in the `collapsed` argument. | ||
| dataValue <- shiny::restoreInput(id = "sidebarCollapsed", default = collapsed) | ||
| if (disable) dataValue <- TRUE |
There was a problem hiding this comment.
Maybe a comment here to about the transition issue that this is a workaround for?
This was referenced May 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is that this will be a commit-sane version of #187