Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass ... to a() in valueBox and infoBox #134

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MarkEdmondson1234
Copy link

@MarkEdmondson1234 MarkEdmondson1234 commented Mar 18, 2016

I needed this for an application I had, but fair play if you don't think it suitable for master branch. Thought I'd put it out there at the very least. Minor change to allow more customisation of the href link for value and Info boxes.

I needed this as otherwise the Shiny app stops/greys out when you click on the link, so I needed to add a target="_blank" to the infoBox. e.g.

url <- reactive_url()

infoBox("Download", 
              href = x, 
              target = "_blank",
              value = "Data,
              subtitle = "Click to download. Up to 1GB per file", 
              icon = icon("download"))

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@MarkEdmondson1234
Copy link
Author

This is 6 years old, is it still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants