Fix observeEvent stack trace stripping #4163
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4162.
Explanation
Reactive objects have a lot of machinery that we generally want to hide, so they call
..stacktraceoff..
before they begin executing and..stacktraceon..
right before they call user-provided code.In the specific case of
observeEvent
, the innerobserve()
call had an explicit..stacktraceon = FALSE
. Once upon a time this was correct, as a line slightly preceding it took care of turning the stack trace back on. But during the introduction ofbindEvent
, that previous line went away.