Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(busy): Show pulse if only UI are recalculating #4137

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

gadenbuie
Copy link
Member

Because recalculating UI elements don't get spinners we shouldn't count these objects in the "shiny is busy and doesn't have any spinners" selector.

https://discord.com/channels/1109483223987277844/1289269846026096652

@gadenbuie gadenbuie requested a review from cpsievert September 27, 2024 19:52
@gadenbuie gadenbuie marked this pull request as ready for review September 27, 2024 19:52
@gadenbuie gadenbuie merged commit 2e2114f into main Sep 30, 2024
@gadenbuie gadenbuie deleted the fix/pulse-for-recalculating-ui branch September 30, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants