Don't treat input/output as draggable inside of absolutePanel(draggable = T)
#3937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
force-pushed
the
jqui-draggable-cancel
branch
from
7600835 to
bdfcefc
Compare
gadenbuie
approved these changes
Nov 1, 2023
cpsievert
changed the title
absolutePanel(draggable = T) from interfering with click/drag events on input/output childrenabsolutePanel(draggable = T)
cpsievert
added a commit
to posit-dev/py-shiny
that referenced
this pull request
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3933
Closes #3752
As a side note, it'd be nice if
draggablecould be a list of options for thedraggable()method, but to do that properly (i.e., support JS functions, per element options, etc) would be non-trivial, and probably best be done via a web component (which could fix other problems with this approach, such as every element with a.draggableclass getting instiantiated everytime a draggable element gets rendered).For now, since we mainly want a targeted fix for #3933, we'll just add a smarter default behavior to prevent input/outputs from being draggable (so we also #3752 for free, virtually).