Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-minified selectize.js source; and respect shiny.minified option #3918

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

cpsievert
Copy link
Collaborator

@cpsievert cpsievert commented Oct 19, 2023

This PR adds a non-minified copy of selectize.js' JavaScript, which will be useful for the eventual fix for #3909 (we'll likely need to patch the JS for the fix).

It also makes it so now, with shiny::devmode() or options(shiny.minified = FALSE), you'll get the non-minified version

@cpsievert cpsievert requested a review from gadenbuie October 19, 2023 23:25
Copy link
Member

@gadenbuie gadenbuie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a separator here

Oops, didn't mean to submit that comment. All looks good to me!

@cpsievert cpsievert merged commit 7069064 into main Oct 19, 2023
@cpsievert cpsievert deleted the selectize-js branch October 19, 2023 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants