Fix selectize event namespacing issues (#3919)

Co-authored-by: cpsievert <[email protected]>
rstudio · Oct 20, 2023 · ce78d0d · ce78d0d
1 parent 7069064
commit ce78d0d
Show file tree

Hide file tree

Showing 4 changed files with 39 additions and 34 deletions.
diff --git a/inst/www/shared/selectize/js/selectize.js b/inst/www/shared/selectize/js/selectize.js
@@ -834,15 +834,18 @@ var Selectize = function($input, settings) {
 
   self.settings = {};
 
+	// increase the count of 'active' (i.e., non-destroyed) selectize instances
+	++Selectize.count;
+
 	$.extend(self, {
 		order            : 0,
 		settings         : settings,
 		$input           : $input,
 		tabIndex         : $input.attr('tabindex') || '',
 		tagType          : input.tagName.toLowerCase() === 'select' ? TAG_SELECT : TAG_INPUT,
 		rtl              : /rtl/i.test(dir),
-
-		eventNS          : '.selectize' + (++Selectize.count),
+		// generate a unique ID for the event namespace
+		eventNS          : '.selectize-' + (new Date().getTime()) + '-' + (Math.random().toString(36).substr(2, 5)),
 		highlightedValue : null,
 		isBlurring       : false,
 		isOpen           : false,

diff --git a/inst/www/shared/selectize/js/selectize.min.js b/inst/www/shared/selectize/js/selectize.min.js
diff --git a/srcts/build/external_libs.ts b/srcts/build/external_libs.ts
@@ -55,6 +55,14 @@ build({
   minify: true,
 });
 
+build({
+  ...opts,
+  entryPoints: [outDir + "selectize/js/selectize.js"],
+  outfile: outDir + "selectize/js/selectize.min.js",
+  minify: true,
+  target: "es6",
+});
+
 build({
   ...opts,
   entryPoints: [outDir + "selectize/accessibility/js/selectize-plugin-a11y.js"],

diff --git a/tools/selectize-patches/007-selectize-event-namespace-bugfix.patch b/tools/selectize-patches/007-selectize-event-namespace-bugfix.patch
@@ -0,0 +1,25 @@
+diff --git a/inst/www/shared/selectize/js/selectize.js b/inst/www/shared/selectize/js/selectize.js
+index 0b447a7b3..cbfe9178e 100644
+--- a/inst/www/shared/selectize/js/selectize.js
++++ b/inst/www/shared/selectize/js/selectize.js
+@@ -834,6 +834,9 @@ var Selectize = function($input, settings) {
+
+   self.settings = {};
+
++	// increase the count of 'active' (i.e., non-destroyed) selectize instances
++	++Selectize.count;
++
+ 	$.extend(self, {
+ 		order            : 0,
+ 		settings         : settings,
+@@ -841,8 +844,8 @@ var Selectize = function($input, settings) {
+ 		tabIndex         : $input.attr('tabindex') || '',
+ 		tagType          : input.tagName.toLowerCase() === 'select' ? TAG_SELECT : TAG_INPUT,
+ 		rtl              : /rtl/i.test(dir),
+-
+-		eventNS          : '.selectize' + (++Selectize.count),
++		// generate a unique ID for the event namespace
++		eventNS          : '.selectize-' + (new Date().getTime()) + '-' + (Math.random().toString(36).substr(2, 5)),
+ 		highlightedValue : null,
+ 		isBlurring       : false,
+ 		isOpen           : false,