Forward visibility hidden for all recalculating widgets, not just tho…

…se with a error message (otherwise spinner won't be visible after a req())
rstudio · Dec 13, 2024 · 7904545 · 7904545
1 parent 99e1327
commit 7904545
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/inst/www/shared/busy-indicators/busy-indicators.css b/inst/www/shared/busy-indicators/busy-indicators.css
diff --git a/srcts/extras/busy-indicators/busy-indicators.scss b/srcts/extras/busy-indicators/busy-indicators.scss
@@ -48,13 +48,14 @@
     }
 
     /*
-      When htmlwidget errors are rendered, an inline `visibility:hidden` is put on the
-      html-widget-output, and the error is put in a sibling element that overlays
-      the output container (this way, the height of the output container doesn't change).
-      Work around this by making the output container itself visible and making 
-      the children (except the spinner) invisible.
+      When htmlwidget errors are rendered, an inline `visibility:hidden` is put
+      on the html-widget-output, and the error message (if any) is put in a
+      sibling element that overlays the output container (this way, the height
+      of the output container doesn't change). Work around this by making the
+      output container itself visible and making the children (except the
+      spinner) invisible.
     */
-    &.html-widget-output:has( + .shiny-output-error) {
+    &.html-widget-output {
       visibility: inherit !important;
       > * {
         visibility: hidden;